Messages in this thread | | | Subject | Re: [PATCH 1/5] hwmon: (tmp102) Use devm_add_action to register cleanup function | From | Guenter Roeck <> | Date | Fri, 24 Jun 2016 07:30:57 -0700 |
| |
Hi Nishanth,
On 06/24/2016 07:13 AM, Nishanth Menon wrote: > On 06/23/2016 07:28 PM, Guenter Roeck wrote: >> By registering a cleanup function with devm_add_action(), we can >> simplify the error path in the probe function and drop the remove >> function entirely. >> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > I dont seem to have a cover letter to reply to... but anyways.. > > Before: http://pastebin.ubuntu.com/17801376/ > After all 5 patches: http://pastebin.ubuntu.com/17801824/ > > Fails on beagleboard-X15 with: > [ 36.781509] tmp102 0-0048: No cache defaults, reading back from HW > [ 36.795940] tmp102 0-0048: unexpected config register value > > I have'nt bisected down on the specific patch in the series. Have you had a chance to test the series? > >
Thanks for testing. Yes, I did test it. Maybe different chip revisions, or different initial config register values and I messed up there. Can you send me the output of i2cdump (word wide) ?
Thanks, Guenter
| |