lkml.org 
[lkml]   [2016]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 7/8] mmc: block: register RPMB partition with the RPMB subsystem
From
Date
On 02/06/16 00:41, Tomas Winkler wrote:
> Register eMMC RPMB partition with the RPMB subsystem and provide
> implementation for the RPMB access operations abstracting
> actual multi step process.
>
> V2: resend
> V3: commit message fix
> V4: Kconfig: use select RPMB to ensure valid configuration
> Switch back to main area after RPMB access
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---

<SNIP>

> +static void mmc_blk_rpmb_add(struct mmc_card *card)
> +{
> + struct mmc_blk_data *md = dev_get_drvdata(&card->dev);
> + struct mmc_blk_data *part_md = mmc_blk_rpmb_part_get(md);
> + struct rpmb_dev *rdev;
> +
> + if (!part_md)
> + return;
> +
> + mmc_blk_rpmb_set_dev_id(&mmc_rpmb_dev_ops, card);
> +
> + /* RPMB blocks are written in half sectors hence '* 2' */
> + mmc_rpmb_dev_ops.reliable_wr_cnt = card->ext_csd.rel_sectors * 2;

This looks like it does not support 8KB writes added in v5.1 spec. Can that
be supported?

> +
> + rdev = rpmb_dev_register(disk_to_dev(part_md->disk),
> + &mmc_rpmb_dev_ops);
> + if (IS_ERR(rdev)) {
> + pr_warn("%s: cannot register to rpmb %ld\n",
> + part_md->disk->disk_name, PTR_ERR(rdev));
> + }
> +}

<SNIP>

\
 
 \ /
  Last update: 2016-06-23 08:41    [W:2.032 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site