lkml.org 
[lkml]   [2016]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 1/5] dma-buf/fence: add .teardown() ops
    On Thu, Jun 23, 2016 at 12:29:46PM -0300, Gustavo Padovan wrote:
    > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
    >
    > fence_array requires a function to clean up its state before we
    > are able to call fence_put() and release it.

    An explanation along the lines of:

    As the array of fence callbacks held by an active struct fence_array
    each has a reference to the struct fence_array, when the owner of the
    fence_array is freed it must dispose of the callback references before
    it can free the fence_array. This can not happen simply during
    fence_release() because of the extra references and so we need a new
    function to run before the final fence_put().

    would help, it is not until you use it in 5/5 that it becomes apparent
    why it is needed.
    -Chris

    --
    Chris Wilson, Intel Open Source Technology Centre

    \
     
     \ /
      Last update: 2016-06-23 23:21    [W:3.386 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site