lkml.org 
[lkml]   [2016]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()
On 23/06/16 02:29, Julian Calaby wrote:
> Hi All,
>
> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
> <luisbg@osg.samsung.com> wrote:
>> The common format to check if a function returned an error pointer is to
>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>>
>> Also, if there was an error returning -EINVAL instead of -1 is more
>> appropriate.
>
> These two changes could be argued to be separate changes deserving of
> their own patches.
>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> However if everyone else is ok with that, this is:
>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
>
> Thanks,
>

Hi Julian,

If you don't mind I will resend as two separate patches and include your
Reviewed-by in both.

Thanks for the review,
Luis

\
 
 \ /
  Last update: 2016-06-23 13:41    [W:0.064 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site