lkml.org 
[lkml]   [2016]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.
On Wed, 22 Jun 2016, Yury Norov wrote:

> > As well as preprocessor indentation, this is missing spaces after '(';
> > check for and fix that issue throughout this patch series. (There are
> > only a few cases where a macro is used to construct a type / variable
> > name, such as ElfW, where missing the space is more usual.)
> >
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com
>
> So, you want have it like this?
> #ifdef __LP64__
> # define RTLD_START RTLD_START_1( "x", "3", "sp" )

Sorry, before '(' in function and function-like-macro calls, as in
standard GNU style.

# define RTLD_START RTLD_START_1 ("x", "3", "sp")

--
Joseph S. Myers
joseph@codesourcery.com

\
 
 \ /
  Last update: 2016-06-22 13:01    [W:0.410 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site