Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit | Date | Tue, 21 Jun 2016 13:41:20 +0200 |
| |
On Monday, June 20, 2016 9:12:50 PM CEST Martin K. Petersen wrote: > >>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes: > > As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints > that with the correct format. The change to use no_printk() > > [...] > > + dprintk("wd7000_biosparam: dev=%s, size=%lld, ", > + bdevname(bdev, b), (s64)capacity); > > s64? > > Why not unsigned long long like we usually do with sector_t?
The printk() was using %d as the format string, printing it as a signed number, so I did not change it.
Using %llu makes sense though, I've resent it like that.
Arnd
| |