Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v12 4/4] power: wm831x_power: Support USB charger current limit management | Date | Tue, 21 Jun 2016 13:30:49 +0300 |
| |
Hi,
Baolin Wang <baolin.wang@linaro.org> writes: > @@ -607,8 +647,31 @@ static int wm831x_power_probe(struct platform_device *pdev) > } > } > > + if (wm831x_pdata && wm831x_pdata->usb_gadget) { > + power->usb_charger = > + usb_charger_find_by_name(wm831x_pdata->usb_gadget);
the fact that you rely on strings and pass them via pdata is an indication that you don't have enough description of the HW. Seems like we need to come up with a set of DT properties which tie a charger to a UDC.
I'm thinking a phandle would be enough?
-- balbi [unhandled content-type:application/pgp-signature]
| |