Messages in this thread | | | From | Andrey Smirnov <> | Date | Tue, 21 Jun 2016 16:06:11 -0700 | Subject | Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently |
| |
On Tue, Jun 21, 2016 at 2:22 PM, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > On 21/06/2016 at 00:22:46 -0700, Andrey Smirnov wrote : >> Report oscillator problems more intelligently, by printing more >> information about what cause the issue and not yelling "SET TIME!" at >> the user. >> > > Well, the proper way of doing that is to ensure that -EINVAL is returned > when reading the time until it has been set once instead of starting the > oscillator and forgetting about that useful information.
Agreed, will change in v3.
| |