Messages in this thread | | | From | Guenter Roeck <> | Date | Mon, 20 Jun 2016 12:36:37 -0700 | Subject | Re: [PATCH v3 01/15] phy: rockchip-emmc: give DLL some extra time to be ready |
| |
On Mon, Jun 20, 2016 at 12:30 PM, Doug Anderson <dianders@chromium.org> wrote: > Hi, > > On Mon, Jun 20, 2016 at 12:23 PM, Guenter Roeck <groeck@google.com> wrote: >> On Mon, Jun 20, 2016 at 10:56 AM, Douglas Anderson >> <dianders@chromium.org> wrote: >>> From: Shawn Lin <shawn.lin@rock-chips.com> >>> >>> According to the databook, 10.2us is the max time for dll to be ready to >>> work. However in testing, some chips need 20us for dll to be ready. This >> >> Nitpick, but description (20uS) and code (more than 25 uS) don't match. > > Good catch. If I spin the series I'll fix this, otherwise I'll assume > that the person applying this (Ulf?) can fix the description at their > discretion. >
Not that it matters much, as the code is replaced in a later patch anyway. It might make more sense to merge the two patches into one.
Guenter
| |