Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() | Date | Mon, 20 Jun 2016 19:47:00 +0200 |
| |
Peter Zijlstra <peterz@infradead.org> writes:
> Could either of you comment on the below patch? > > All atomic functions that return a value should imply full memory > barrier semantics -- this very much includes a compiler barrier / memory > clobber.
I wonder if it is possible to find a case where this makes a real difference, ie. where the compiler erroneously reused a value due to the missing barrier.
Andreas.
-- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
| |