[lkml]   [2016]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V2] pinctrl: Don't create a pinctrl handle if no pinctrl entries exist
On Thu, Jun 16, 2016 at 5:27 PM, Jon Hunter <> wrote:

> When pinctrl_get() is called for a device, it will return a valid handle
> even if the device itself has no pinctrl state entries defined in
> device-tree. This is caused by the function pinctrl_dt_to_map() which
> will return success even if the first pinctrl state, 'pinctrl-0', is not
> found in the device-tree node for a device.
> According to the pinctrl device-tree binding documentation, pinctrl
> states must be numbered starting from 0 and so 'pinctrl-0' should always
> be present if a device uses pinctrl and therefore, if 'pinctrl-0' is not
> present it seems valid that we should not return a valid pinctrl handle.
> Fix this by returning an error code if the property 'pinctrl-0' is not
> present for a device.
> Signed-off-by: Jon Hunter <>

Patch applied (after adding OF to the subject)

It's a bit dangerous because it changes semantics but let's see
if we survive it.

> I was wondering if this meant we are creating pinctrl handles for
> devices on boot that don't use pinctrl (when
> calling pinctrl_bind_pins()). However, although devm_pinctrl_get()
> does return successful for all devices, the subsequent call to
> pinctrl_lookup_state() (to get the default state) will fail and so
> we will destroy the pinctrl handle afterall.

It's better like this, logically. I'm just worried that there may be
code in the tree that depend on the bind always getting a handle.

Linus Walleij

 \ /
  Last update: 2016-06-18 11:21    [W:0.035 / U:91.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site