lkml.org 
[lkml]   [2016]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control
Hi!

> -</section>
> +
> + <section id="voice-coil-controls">
> + <title>Voice Coil Control Reference</title>
> +
> + <para>The Voice Coil class controls are used to control voice
> + coil lens devices. These are very simple devices that consist of
> + a voice coil, a spring and a lens. The current applied on a

"on the"?

> + voice coil is used to move the lens away from the resting
> + position which typically is (close to) infinity.</para>

Insert explanation that this all is for autofocus somewhere?

> /* User-class control IDs */
>
> @@ -974,4 +975,10 @@ enum v4l2_detect_md_mode {
> #define V4L2_CID_DETECT_MD_THRESHOLD_GRID (V4L2_CID_DETECT_CLASS_BASE + 3)
> #define V4L2_CID_DETECT_MD_REGION_GRID (V4L2_CID_DETECT_CLASS_BASE + 4)
>
> +/* Voice coil lens driver control IDs defined by V4L2 */

Too many spaces after '/*'.

Otherwise, you have my "acked-by".

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

\
 
 \ /
  Last update: 2016-06-18 00:41    [W:0.338 / U:26.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site