Messages in this thread | | | From | Len Brown <> | Date | Thu, 16 Jun 2016 22:39:16 -0400 | Subject | Re: [PATCH 04/20] x86, intel_idle: use Intel family macros for intel_idle |
| |
On Thu, Jun 2, 2016 at 8:19 PM, Dave Hansen <dave@sr71.net> wrote: > > From: Dave Hansen <dave.hansen@linux.intel.com> > > Use the new INTEL_FAM6_* macros for intel_idle.c. Also fix up > some of the macros to be consistent with how some of the > intel_idle code refers to the model. > > There's on oddity here: model 0x1F is uniquely referred to here > and nowhere else that I could find. 0x1E/0x1F are just spelled > out as "Intel Core i7 and i5 Processors" in the SDM or as "Intel > processors based on the Nehalem, Westmere microarchitectures" in > the RDPMC section. Comments between tables 19-19 and 19-20 in > the SDM seem to point to 0x1F being some kind of Westmere, so > let's call it "WESTMERE2". >
> #define INTEL_FAM6_NEHALEM_EP 0x1A > #define INTEL_FAM6_NEHALEM_EX 0x2E > #define INTEL_FAM6_WESTMERE 0x25 > +#define INTEL_FAM6_WESTMERE2 0x1F
Model 0x1F, like 1A and 1E is a Nehalem, not a Westmere. This can be seen in the current SDM section 35.5.
For the historians, I believe that the name "Havendale" was originally associated with that model# -- though I don't know if that binding persisted.
My NHM desktop is a 1A, though, not a 1F.
thanks, Len Brown, Intel Open Source Technology Center
| |