lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] init, allow blacklisting of module_init functions
Date
sprint_symbol_no_offset() returns the string "function_name [module_name]"
where [module_name] is not printed for built in kernel functions. This
means that the blacklisting code will fail when comparing module function
names with the extended string. This patch adds the functionality to
block a module's module_init() function by finding the space in the string
and truncating the comparison to that length.

[v2]: linux@rasmusvillemoes.dk, switch to strreplace()

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Yang Shi <yang.shi@linaro.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Kees Cook <keescook@chromium.org>
Cc: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
init/main.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/init/main.c b/init/main.c
index 4c17fda5c2ff..e8fb1b537d08 100644
--- a/init/main.c
+++ b/init/main.c
@@ -713,6 +713,11 @@ static bool __init_or_module initcall_blacklisted(initcall_t fn)
return false;

sprint_symbol_no_offset(fn_name, (unsigned long)fn);
+ /*
+ * fn will be "function_name [module_name]" where [module_name] is not
+ * displayed for built-in init functions. Strip off the [module_name].
+ */
+ strreplace(fn_name, ' ', '\0');

list_for_each_entry(entry, &blacklisted_initcalls, next) {
if (!strcmp(fn_name, entry->buf)) {
--
1.7.9.3
\
 
 \ /
  Last update: 2016-06-17 03:41    [W:0.053 / U:23.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site