Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 16 Jun 2016 09:20:15 +0200 | Subject | Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 |
| |
On Thu, Jun 16, 2016 at 2:20 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 06/15, Linus Walleij wrote: >> @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev) >> u32 ack; >> int i; >> >> - ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT)); >> - for (i = 0; i < RPM_SELECT_SIZE; i++) >> - writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i)); >> - writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT)); >> + ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off)); >> + for (i = 0; i < rpm->data->sel_size; i++) >> + writel_relaxed(0, >> + RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i)); >> + writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off)); > > Does the ack size vary though? I thought that was always 7. It > seems that really only the request selector size varies?
Ah you're right, I'll send a patch on top of this one fixing it up.
Yours, Linus Walleij
| |