lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival
Date
On Thu 16-06-16 08:19 PM, Michal Hocko wrote:
>
> On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote:
> I am not able to find clear reasons why we shouldn't do it for the rest.
> Ok so what do we do now? I'll send v2 with proposed changes.
> Then do we still want to have stats on those pvecs?
> In my opinion it's not worth it now.
>
> I think the fix has a higher priority - we also want to backport it to
> stable trees IMO. We can discuss the stats and how to present them
> later.

Will send the patch tomorrow. In the meantime I was able get similar
problem on lru_deactivate by using MADV_FREE:

LRU_add 588 = 18704kB
LRU_rotate 0 = 0kB
LRU_deactivate 165 = 309304kB
LRU_deact_file 0 = 0kB
LRU_activate 0 = 0kB

Thanks,
Lukas

\
 
 \ /
  Last update: 2016-06-16 22:21    [W:0.063 / U:4.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site