lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks
On Thu, Jun 16, 2016 at 10:21 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Thu, Jun 16, 2016 at 4:10 AM, Vladimir Davydov
> <vdavydov@virtuozzo.com> wrote:
>> On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote:
>> ...
>>> @@ -225,7 +225,8 @@ static void account_kernel_stack(struct thread_info *ti, int account)
>>> {
>>> struct zone *zone = page_zone(virt_to_page(ti));
>>>
>>> - mod_zone_page_state(zone, NR_KERNEL_STACK, account);
>>> + mod_zone_page_state(zone, NR_KERNEL_STACK,
>>> + THREAD_SIZE / PAGE_SIZE * account);
>>
>> It won't work if THREAD_SIZE < PAGE_SIZE. Is there an arch with such a
>> thread size, anyway? If no, we should probably drop thread_info_cache.
>
> On a quick grep, I can't find any. I'll add a BUILD_BUG_ON for now.

Correction. frv has 16KiB pages and 8KiB stacks. I'll rework it to
count NR_KERNEL_STACK in KiB. Sigh.

--Andy

>
> --Andy



--
Andy Lutomirski
AMA Capital Management, LLC

\
 
 \ /
  Last update: 2016-06-16 22:01    [W:0.070 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site