lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
From
Date
On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote:
> On 2016/06/13 11:46, Netanel Belgazal wrote:
[...]
> > +static ssize_t ena_show_small_copy_len(struct device *dev,
> > +        struct device_attribute *attr, char *buf)
> > +{
> > + struct ena_adapter *adapter = dev_get_drvdata(dev);
> > +
> > + return sprintf(buf, "%d\n", adapter->small_copy_len);
> > +}
> > +
> > +static DEVICE_ATTR(small_copy_len, S_IRUGO | S_IWUSR, ena_show_small_copy_len,
> > +    ena_store_small_copy_len);
>
> This is what many other drivers call (rx_)copybreak. Perhaps it's time
> to add it to ethtool as well?
[...]

There is the 'tunable' ethtool API for random parameters like
rx_copybreak.  The ethtool utility doesn't support it yet, though.

Ben.

--
Ben Hutchings
Life is what happens to you while you're busy making other plans.
                                                               - John
Lennon
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-16 20:41    [W:0.222 / U:1.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site