lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] rtlwifi: use s8 instead of char
Date
From: Arnd Bergmann
> On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote:
> >
> > Arnd,
> >
> > rtlwifi and rtl8xxxu are two distinct drivers managed by different
> > people. I'd be really nice if you could split this into a per driver
> > patch.
> >
> > That said, the use of char in rtl8xxxu is all as a flag indicator, so I
> > don't think the s/char/s8/ conversion is justified. I used char rather
> > than ugly bool to reduce the size of the struct.
>
> Makes sense, I'll resend without that change. If anything, the flag
> should become u8, not s8 anyway.

Does bool:8 work ?

David

\
 
 \ /
  Last update: 2016-06-16 18:41    [W:0.055 / U:5.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site