lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data structures
On Thu, 16 Jun 2016, Lee Jones wrote:

> On Sat, 11 Jun 2016, Bin Gao wrote:
>
> > This patch adds three new data structures: struct trip_config_map {},
> > struct thermal_irq_map {} and struct pmic_thermal_data {} which are
> > required by some new drivers.
> >
> > Signed-off-by: ysiyer <yegnesh.s.iyer@intel.com>
> > Signed-off-by: Bin Gao <bin.gao@intel.com>
> > ---
> > include/linux/mfd/intel_soc_pmic.h | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
>
> Please place the addition of the structs into the patches which use
> them first.

Oh, and when you submit patch-sets, please ensure they are
'threaded'. Or else they have a tendency to spread themselves to the
four winds in people's Inboxes.

Please fix the subject line too (in all of your patches). To help
with this you should always do a:

`git log --oneline -- <subsystem>`

> > diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h
> > index cf619db..7df4302 100644
> > --- a/include/linux/mfd/intel_soc_pmic.h
> > +++ b/include/linux/mfd/intel_soc_pmic.h
> > @@ -21,6 +21,27 @@
> >
> > #include <linux/regmap.h>
> >
> > +struct trip_config_map {
> > + u16 irq_reg;
> > + u16 irq_en;
> > + u16 evt_stat;
> > + u8 irq_mask;
> > + u8 irq_en_mask;
> > + u8 evt_mask;
> > + u8 trip_num;
> > +};
> > +
> > +struct thermal_irq_map {
> > + char handle[20];
> > + int num_trips;
> > + struct trip_config_map *trip_config;
> > +};
> > +
> > +struct pmic_thermal_data {
> > + struct thermal_irq_map *maps;
> > + int num_maps;
> > +};
> > +
> > struct intel_soc_pmic {
> > int irq;
> > struct regmap *regmap;
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2016-06-16 17:21    [W:0.051 / U:5.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site