lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver
From
Date


On 15/06/16 21:07, Kenneth Westfield wrote:
> On Wed, Jun 15, 2016 at 10:31:36AM +0100, Mark Brown wrote:
>> On Wed, Jun 15, 2016 at 10:16:27AM +0100, Srinivas Kandagatla wrote:
>>> On 14/06/16 16:59, Mark Brown wrote:
>>>> On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote:
>
>>> In theory there are 3 devices,
>>> one is the pmic-spmi driver, which provides regmap access to analog part of
>>> codec registers.
>>> second is syscon driver which provides regmap access to digital parts of
>>> codec to codec driver.
>>> third is the codec driver which uses both the above.
>>
>>> Codec registers range is just split into two, range 0x0- 0x200 sits in pmic
>>> address space and range 0x201 - 0x4ff in the SOC address space,
>>
>>> Are there any other better ways to model this kinda driver?
>>
>> Why not just have separate devices for each of the register maps?
>
> Srinivas,
>
> Mark has a good point. Also, by having distinct devices and drivers;
> you should make use of ASoC's supporting wrappers for regmap accesses.

Yep, Let to try that and see how it looks.

thanks,
srini
>

\
 
 \ /
  Last update: 2016-06-16 16:01    [W:0.094 / U:2.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site