lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] KVM: VMX: validate individual bits of guest MSR_IA32_FEATURE_CONTROL
On 06/16/16 11:55, Paolo Bonzini wrote:
>
>
> On 16/06/2016 08:05, Haozhong Zhang wrote:
> > + /*
> > + * Only bits masked by msr_ia32_feature_control_valid_bits can be set in
> > + * msr_ia32_feature_control.
> > + *
> > + * msr_ia32_feature_control_valid_bits should be modified by
> > + * feature_control_valid_bits_add/del(), and only bits masked by
> > + * FEATURE_CONTROL_MAX_VALID_BITS can be modified.
> > + */
> > u64 msr_ia32_feature_control;
> > + u64 msr_ia32_feature_control_valid_bits;
>
> I noticed that the fw_cfg patch used an uint32_t. It probably should
> use uint64_t; what you did here is correct.
>

I'll fix there.

Thanks,
Haozhong

\
 
 \ /
  Last update: 2016-06-16 14:01    [W:0.090 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site