Messages in this thread | | | Date | Thu, 16 Jun 2016 11:39:37 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v3 1/2] mfd: ti-smusbdig: Add support for the TI SM-USB-DIG |
| |
On Wed, 15 Jun 2016, Andrew F. Davis wrote:
> On 06/15/2016 10:43 AM, Lee Jones wrote: > > This requires a USB Ack. > > > >> The TI SM-USB-DIG is a USB to SPI/I2C/1Wire/GPIO adapter. > >> Add MFD core support. > >> > >> Signed-off-by: Andrew F. Davis <afd@ti.com> > >> --- > > > > Where is the change log from v1 => v2? > > > > Looking at a diff of the two it looks like all the changes are related > to your v1 feedback: > > - Rename sm-usb-dig -> ti-smusbdig > - Inline helper functions in header > - Alphabetize includes
Please ensure this is added when you submit subsequent sets. It really does help with the review and saves a great deal of time.
> >> Changes from v2: > >> - Add missing dependency on USB, thanks kbuild test robot > >> > >> drivers/mfd/Kconfig | 9 +++ > >> drivers/mfd/Makefile | 2 + > >> drivers/mfd/ti-smusbdig.c | 138 ++++++++++++++++++++++++++++++++++++++++ > >> include/linux/mfd/ti-smusbdig.h | 75 ++++++++++++++++++++++ > >> 4 files changed, 224 insertions(+) > >> create mode 100644 drivers/mfd/ti-smusbdig.c > >> create mode 100644 include/linux/mfd/ti-smusbdig.h > >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |