lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"
From
Date
On 06/16/2016 11:22 AM, Vitaly Kuznetsov wrote:
> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count,
> field of the struct page, to _refcount") broke kdump. makedumpfile(8) does
> stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While
> it is definitely possible to fix this particular tool I'm not sure about
> other tools which might be doing the same.
>
> I suggest we remember the "we don't break userspace" rule and revert for
> 4.7 while it's not too late.

I don't think the rule applies to tools such as kdump and crash, or e.g.
systemtap, that interact with kernel internals even though they are
technically "userspace". They have to adapt to new kernel versions all
the time, the internal APIs are not frozen. Otherwise we would be quite
limited in evolving the kernel...

So even though the change in question is not essential (field rename)
and reverting wouldn't really hurt technical progress, this is not a
sufficient reason, IMO. Thus, NAK.

Vlastimil

\
 
 \ /
  Last update: 2016-06-16 12:01    [W:0.116 / U:1.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site