lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf mem: Add --ldlat option
    Commit-ID:  b0d745b3c34a7fd9ee0b78b929b94c706f84e341
    Gitweb: http://git.kernel.org/tip/b0d745b3c34a7fd9ee0b78b929b94c706f84e341
    Author: Jiri Olsa <jolsa@kernel.org>
    AuthorDate: Tue, 14 Jun 2016 20:19:11 +0200
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Wed, 15 Jun 2016 10:35:27 -0300

    perf mem: Add --ldlat option

    Adding --ldlat option to specify desired latency for loads event.

    Specify 50 as loads event latency:

    $ perf mem record -e ldlat-loads -v --ldlat 50 true
    calling: record -W -d -e cpu/mem-loads,ldlat=50/P true

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1465928361-2442-2-git-send-email-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/Documentation/perf-mem.txt | 3 +++
    tools/perf/builtin-mem.c | 1 +
    tools/perf/util/mem-events.c | 17 ++++++++++++++++-
    tools/perf/util/mem-events.h | 1 +
    4 files changed, 21 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/Documentation/perf-mem.txt b/tools/perf/Documentation/perf-mem.txt
    index 1d6092c..7349632 100644
    --- a/tools/perf/Documentation/perf-mem.txt
    +++ b/tools/perf/Documentation/perf-mem.txt
    @@ -56,6 +56,9 @@ OPTIONS
    --all-user::
    Configure all used events to run in user space.

    +--ldload::
    + Specify desired latency for loads event.
    +
    SEE ALSO
    --------
    linkperf:perf-record[1], linkperf:perf-report[1]
    diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
    index 1dc140c..d608a2c 100644
    --- a/tools/perf/builtin-mem.c
    +++ b/tools/perf/builtin-mem.c
    @@ -67,6 +67,7 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
    OPT_CALLBACK('e', "event", &mem, "event",
    "event selector. use 'perf mem record -e list' to list available events",
    parse_record_events),
    + OPT_UINTEGER(0, "ldlat", &perf_mem_events__loads_ldlat, "mem-loads latency"),
    OPT_INCR('v', "verbose", &verbose,
    "be more verbose (show counter open errors, etc)"),
    OPT_BOOLEAN('U', "--all-user", &all_user, "collect only user level data"),
    diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
    index 75465f8..bbc368e 100644
    --- a/tools/perf/util/mem-events.c
    +++ b/tools/perf/util/mem-events.c
    @@ -10,18 +10,33 @@
    #include "debug.h"
    #include "symbol.h"

    +unsigned int perf_mem_events__loads_ldlat = 30;
    +
    #define E(t, n, s) { .tag = t, .name = n, .sysfs_name = s }

    struct perf_mem_event perf_mem_events[PERF_MEM_EVENTS__MAX] = {
    - E("ldlat-loads", "cpu/mem-loads,ldlat=30/P", "mem-loads"),
    + E("ldlat-loads", "cpu/mem-loads,ldlat=%u/P", "mem-loads"),
    E("ldlat-stores", "cpu/mem-stores/P", "mem-stores"),
    };
    #undef E

    #undef E

    +static char mem_loads_name[100];
    +static bool mem_loads_name__init;
    +
    char *perf_mem_events__name(int i)
    {
    + if (i == PERF_MEM_EVENTS__LOAD) {
    + if (!mem_loads_name__init) {
    + mem_loads_name__init = true;
    + scnprintf(mem_loads_name, sizeof(mem_loads_name),
    + perf_mem_events[i].name,
    + perf_mem_events__loads_ldlat);
    + }
    + return mem_loads_name;
    + }
    +
    return (char *)perf_mem_events[i].name;
    }

    diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
    index 5d6d930..7f69bf9 100644
    --- a/tools/perf/util/mem-events.h
    +++ b/tools/perf/util/mem-events.h
    @@ -18,6 +18,7 @@ enum {
    };

    extern struct perf_mem_event perf_mem_events[PERF_MEM_EVENTS__MAX];
    +extern unsigned int perf_mem_events__loads_ldlat;

    int perf_mem_events__parse(const char *str);
    int perf_mem_events__init(void);
    \
     
     \ /
      Last update: 2016-06-16 10:41    [W:4.061 / U:1.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site