lkml.org 
[lkml]   [2016]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/19] perf stdio: Do not pass hists in hist_entry__fprintf
    Date
    From: Jiri Olsa <jolsa@kernel.org>

    There's no need, we have the hists pointer in struct hist_entry.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1465928361-2442-8-git-send-email-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/ui/stdio/hist.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
    index 5d007836d9a7..150c4de33b22 100644
    --- a/tools/perf/ui/stdio/hist.c
    +++ b/tools/perf/ui/stdio/hist.c
    @@ -492,7 +492,6 @@ out:
    }

    static int hist_entry__fprintf(struct hist_entry *he, size_t size,
    - struct hists *hists,
    char *bf, size_t bfsz, FILE *fp)
    {
    int ret;
    @@ -500,6 +499,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
    .buf = bf,
    .size = size,
    };
    + struct hists *hists = he->hists;
    u64 total_period = hists->stats.total_period;

    if (size == 0 || size > bfsz)
    @@ -755,7 +755,7 @@ size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows,
    if (percent < min_pcnt)
    continue;

    - ret += hist_entry__fprintf(h, max_cols, hists, line, linesz, fp);
    + ret += hist_entry__fprintf(h, max_cols, line, linesz, fp);

    if (max_rows && ++nr_rows >= max_rows)
    break;
    --
    2.5.5
    \
     
     \ /
      Last update: 2016-06-15 20:41    [W:4.093 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site