lkml.org 
[lkml]   [2016]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 4/8] arm64: parse cpu capacity-dmips-mhz from DT
On 15/06/16 14:49, Mark Brown wrote:
> On Wed, Jun 15, 2016 at 11:17:53AM +0100, Juri Lelli wrote:
>
> > + if (!raw_capacity) {
> > + raw_capacity = kzalloc(sizeof(*raw_capacity) *
> > + num_possible_cpus(), GFP_KERNEL);
>
> kcalloc()?
>

Right. Will change.

> > + if (!raw_capacity) {
> > + pr_err("cpu_capacity: failed to allocate memory"
> > + " for raw capacities\n");
>
> It's normally better to avoid splitting errors message so people can
> grep if they see the error.
>

Tried to avoid breaking 80 columns. But, we seem to have longer pr_err
strings already. I'll change that.

> > + } else {
> > + pr_err("cpu_capacity: missing %s raw capacity "
> > + "(fallback to 1024 for all CPUs)\n",
> > + cpu_node->full_name);
>
> That's going to complain fairly loudly for all existing DTs isn't it and
> it's kind of redundant if all the cores have the same capacity (which is
> a very common case)? How about printing an error only if we already
> found one, or printing a single warning at the end if we didn't get
> anything?

Right, I'll change the condition for which pr_err is emitted. I think
the situation for which we care the most about is when we find partial
information in DT.

Thanks,

- Juri

\
 
 \ /
  Last update: 2016-06-15 17:21    [W:0.054 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site