lkml.org 
[lkml]   [2016]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards
On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote:
> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote:

> > +sound {
> > + compatible = "rockchip,rk3399-gru-sound";
> > + rockchip,cpu = <&i2s0>;
> > + rockchip,codec = <&max98357a &rt5514 &da7219>;

> These seem fairly standard though a variety of versions in the bindings.
> Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark?

Well, the roles aren't actually that standard (the fact that there's
multiple CODECs and one CPU DAI here is really odd and definitely needs
a very system specific interpretation). If they were standard we
already have the simple-card binding that things should be using.
There's no point in standard property names if the interpretation has to
be non-standard.

The vendor specific prefixes are there because all bindings are supposed
to add prefixes to property names.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-15 12:41    [W:0.092 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site