Messages in this thread | | | Date | Wed, 15 Jun 2016 09:23:26 +0100 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] dax: use devm_add_action_or_reset |
| |
On Tue, Jun 14, 2016 at 04:28:43PM -0700, Dan Williams wrote: > On Sun, Jun 12, 2016 at 7:48 AM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > If devm_add_action() fails we are explicitly calling the cleanup to free > > the resources allocated. Lets use the helper devm_add_action_or_reset() > > and return directly in case of error, as we know that the cleanup > > function has been already called by the helper if there was any error. > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > Reviewed-by: Dan Williams <dan.j.williams@intel.com> > > > --- > > > > There is no maintainer mentioned for this driver, so not sure who should > > this patch go through. > > *raises hand*, I'll make sure MAINTAINERS gets updated, for this one > it seems Andrew has already taken it. I notice that drivers/nvdimm/ > could use the same cleanup. I'll take a look unless you beat me to > it.
I will give you an advantage in the race, i will not see that before saturday. :)
Regards Sudip
| |