lkml.org 
[lkml]   [2016]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] zram: update zram to use zpool
On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote:
> Change zram to use the zpool api instead of directly using zsmalloc.
> The zpool api doesn't have zs_compact() and zs_pool_stats() functions.
> I did the following two things to fix it.
> 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to
> call zs_compact() in zsmalloc.
> 2) The 'pages_compacted' attribute is showed in zram by calling
> zs_pool_stats(). So in order not to call zs_pool_state() I move the
> attribute to zsmalloc.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

NACK.

I already explained why.
http://lkml.kernel.org/r/20160609013411.GA29779@bbox

\
 
 \ /
  Last update: 2016-06-16 01:21    [W:1.271 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site