lkml.org 
[lkml]   [2016]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info
Date
Hi,

Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:

>> - id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID);
>> + of_id = of_match_node(mv88e6xxx_of_id_table, np);
>
> You could use of_device_get_match_data() here.
>
>> + if (!of_id)
>> + return -EINVAL;
>> +
>> + info = (const struct mv88e6xxx_info *)of_id->data;
>
> Pointer casts from 'void *' are automatic.

I applied your comments and also squashed patches 7 and 8 together.
I'll respin a v3 soon unless there are other comments.

Thanks,

Vivien

\
 
 \ /
  Last update: 2016-06-14 23:21    [W:1.290 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site