lkml.org 
[lkml]   [2016]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes
On Sun, Jun 12, 2016 at 05:33:24PM +0800, Hillf Danton wrote:
> > - /*
> > - * We put equal pressure on every zone, unless one zone has way too
> > - * many pages free already. The "too many pages" is defined as the
> > - * high wmark plus a "gap" where the gap is either the low
> > - * watermark or 1% of the zone, whichever is smaller.
> > - */
> > - balance_gap = min(low_wmark_pages(zone), DIV_ROUND_UP(
> > - zone->managed_pages, KSWAPD_ZONE_BALANCE_GAP_RATIO));
> > + nr_to_reclaim += max(high_wmark_pages(zone), SWAP_CLUSTER_MAX);
> > + }
>
> Missing sc->nr_to_reclaim = nr_to_reclaim; ?
>

Yes. It may explain why I saw lower than expected kswapd in more
detailed tests recently. Thanks.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2016-06-14 17:41    [W:0.035 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site