lkml.org 
[lkml]   [2016]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/27] mm, vmscan: Move lru_lock to the node
On Fri, Jun 10, 2016 at 06:39:26PM +0200, Vlastimil Babka wrote:
> > @@ -5944,10 +5944,10 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat)
> > zone->min_slab_pages = (freesize * sysctl_min_slab_ratio) / 100;
> > #endif
> > zone->name = zone_names[j];
> > + zone->zone_pgdat = pgdat;
> > spin_lock_init(&zone->lock);
> > - spin_lock_init(&zone->lru_lock);
> > + spin_lock_init(zone_lru_lock(zone));
>
> This means the same lock will be inited MAX_NR_ZONES times. Peterz told
> me it's valid but weird. Probably better to do it just once, in case
> lockdep/lock debugging gains some checks for that?
>

Good point and it's an easy fix.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2016-06-14 17:21    [W:0.132 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site