lkml.org 
[lkml]   [2016]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kconfig.h: use already defined macros for IS_REACHABLE() define
Hi Nicolas,

2016-06-07 7:03 GMT+09:00 Nicolas Pitre <nicolas.pitre@linaro.org>:
> On Tue, 7 Jun 2016, Masahiro Yamada wrote:
>
>> Because config_enabled() is so useful,
>> maybe people tend to abuse it.
>>
>> I see one case where config_enabled() is used
>> for a non-config macro.
>>
>> #define __EXPORT_SYMBOL(sym, sec) \
>> __cond_export_sym(sym, sec, config_enabled(__KSYM_##sym))
>
> Here the need is for a macro that returns 1 or 0 whether given
> symbol is defined or not, exactly as explained in the comment above the
> definition for config_enabled() which in itself has nothing to do with
> config.
>
> So maybe config_enabled() should be renamed to __is_defined() or
> similar, and then config_enabled() or its replacement defined in termps
> of it.

__is_defined() seems reasonable to me, so I've sent an updated series.





--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2016-06-14 08:21    [W:1.618 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site