Messages in this thread | | | Subject | Re: net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288 | From | Giuseppe CAVALLARO <> | Date | Mon, 13 Jun 2016 08:46:10 +0200 |
| |
On 6/11/2016 3:00 AM, Vincent Palatin wrote: > In order to support Wake-On-Lan when using the RK3288 integrated MAC > (with an external RGMII PHY), we need to avoid shutting down the regulator > of the external PHY when the MAC is suspended as it's currently done in the MAC > platform code. > As a first step, create independant callbacks for suspend/resume rather than > re-using exit/init callbacks. So the dwmac platform driver can behave differently > on suspend where it might skip shutting the PHY and at module unloading. > Then update the dwmac-rk driver to switch off the PHY regulator only if we are > not planning to wake up from the LAN. > Finally add the PMT interrupt to the MAC device tree configuration, so we can > wake up the core from it when the PHY has received the magic packet.
IMO these could be sent for net-next and also other glue logic files should be reworked in order to use the new API for coherence.
Peppe
| |