lkml.org 
[lkml]   [2016]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/7] staging: wilc1000: Replace semaphore cfg_event with completion
    Date
    On Monday, June 13, 2016 4:07:35 PM CEST Binoy Jayan wrote:
    > The semaphore 'cfg_event' is used as completion, so convert
    > it to a struct completion type.
    >
    > Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>

    The change looks good, but


    > netdev_dbg(vif->ndev, "Set Timed Out\n");
    > ret_size = 0;
    > }
    > +
    > wilc->cfg_frame_in_use = 0;
    > wilc->cfg_frame_offset = 0;
    > wilc->cfg_seq_no += 1;
    > @@ -1246,6 +1247,7 @@ int wilc_wlan_cfg_get(struct wilc_vif *vif, int start, u16 wid, int commit,
    > {
    > u32 offset;
    > int ret_size;
    > +
    > struct wilc *wilc = vif->wilc;
    >
    > if (wilc->cfg_frame_in_use)
    >

    These two extra newlines seem unrelated to the other changes and probably
    slipped in by accident. The first one is actually ok according to
    normal coding style, while the second one looks misplaced.

    In general, it's better not to touch whitespace when doing other changes,
    except when you are fixing the same code you modify anyway.

    Arnd

    \
     
     \ /
      Last update: 2016-06-13 16:41    [W:4.179 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site