lkml.org 
[lkml]   [2016]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [mmots-2016-06-09-16-49] sleeping function called from slab_alloc()
On Fri 10-06-16 14:59:16, Andrew Morton wrote:
> On Fri, 10 Jun 2016 11:55:54 +0200 mhocko <mhocko@suse.de> wrote:
>
> > On 2016-06-10 11:50, Sergey Senozhatsky wrote:
> > > Hello,
> > >
> > > forked from http://marc.info/?l=linux-mm&m=146553910928716&w=2
> > >
> > > new_slab()->BUG->die()->exit_signals() can be called from atomic
> > > context: local IRQs disabled in slab_alloc().
> >
> > I have sent a patch to drop the BUG() from that path today. It
> > is just too aggressive way to react to a non-critical bug.
> > See
> > http://lkml.kernel.org/r/1465548200-11384-2-git-send-email-mhocko@kernel.org
>
> Doesn't this simply mean that Sergey's workload will blurt a pr_warn()
> rather than a BUG()? That still needs fixing. Confused.

Yes that should be fixed by
http://lkml.kernel.org/r/20160610074223.GC32285@dhcp22.suse.cz

which prevents from using a wrong GFP...

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2016-06-13 13:21    [W:0.037 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site