Messages in this thread Patch in this message | | | Date | Wed, 1 Jun 2016 10:41:00 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v7 13/14] perf callchain: Support x86 target platform |
| |
On Tue, May 31, 2016 at 11:19:11AM +0000, He Kuang wrote:
SNIP
> diff --git a/tools/perf/util/libunwind/x86_32.c b/tools/perf/util/libunwind/x86_32.c > new file mode 100644 > index 0000000..46b4111 > --- /dev/null > +++ b/tools/perf/util/libunwind/x86_32.c > @@ -0,0 +1,18 @@ > +#define REMOTE_UNWIND_LIBUNWIND > + > +#define LIBUNWIND__ARCH_REG_ID libunwind__x86_reg_id > + > +#include "unwind.h" > +#include "debug.h" > +#include "libunwind-x86.h" > +#include <../../../../arch/x86/include/uapi/asm/perf_regs.h> > + > +#undef HAVE_ARCH_X86_64_SUPPORT > +#include "../../arch/x86/util/unwind-libunwind.c" > + > +#undef NO_LIBUNWIND_DEBUG_FRAME > +#define NO_LIBUNWIND_DEBUG_FRAME so debug_frame is explicitly switched off for remote unwind? 2 things:
- could we have some comments/reasonning for un/setting defines in here (and the other arch files) - could you please use the #ifndef XXX #define XXX #endif way
thanks, jirka
| |