lkml.org 
[lkml]   [2016]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support
    Hi Vinod,

    On Mon, 02 May 2016, Vinod Koul wrote:

    > On Wed, Apr 27, 2016 at 01:59:23PM +0100, Peter Griffin wrote:
    > > > bunch of this seems similar to cyclic case, can you create common setup
    > > > routine for these, anyway cyclic is a special cases of slave_sg
    > >
    > > In v4 I've made a st_fdma_prep_common() which abstracts out all the common
    > > checks at the beginning of the *_prep*() functions.
    > >
    > > In v3 fill_fw_node() is already (from one of your previous reviews)
    > > abstracting out all the common parts from these loops. So everything
    > > that is now left is actually differences between the two setups.
    > >
    > > Is that Ok?
    >
    > Sounds better
    >
    > > > and you irq is still enabled and tasklets can be scheduled!!
    > > >
    > > Eeek! Very good point. Also looking at some other drivers we
    > > should be doing a of_dma_controller_free() and
    > > dma_async_device_unregister().
    > >
    > > So something like this: -
    > >
    > > st_fdma_disable(); /*disables irqs*/
    > > of_dma_controller_free(pdev->dev.of_node);
    > > dma_async_device_unregister(&priv->slave);
    > > st_fdma_clk_disable(fdev);
    >
    > you can call devm_free_irq() explictyly, that will syncronize irq and
    > free it up.

    Ok will do/

    > Also you should kill the tasklet afterwards.
    >
    We aren't using a tasklet in this driver.

    Peter.

    \
     
     \ /
      Last update: 2016-05-09 19:41    [W:4.596 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site