Messages in this thread | | | Date | Mon, 9 May 2016 10:31:25 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount |
| |
On Thu 05-05-16 18:29:55, Toshi Kani wrote: > When a partition is not aligned by 4KB, mount -o dax succeeds, > but any read/write access to the filesystem fails, except for > metadata update. > > Call bdev_supports_dax() to perform proper precondition checks > which includes this partition alignment check. > > Signed-off-by: Toshi Kani <toshi.kani@hpe.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Cc: Christoph Hellwig <hch@infradead.org> > Cc: Boaz Harrosh <boaz@plexistor.com>
Looks good to me. Since this patch depends on the first two in your series, just feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
and merge it along with other patches. I've removed the ext2 patch from the previous version from my tree.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |