lkml.org 
[lkml]   [2016]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"
    From
    David,

    On Wed, May 4, 2016 at 7:13 AM, David Wu <david.wu@rock-chips.com> wrote:
    > Signed-off-by: David Wu <david.wu@rock-chips.com>

    Usually folks like a description and not just a subject line. I'd add
    a description like:

    The "div_high" and "div_low" values are always used together. Group them
    into a structure to make it easier to pass them both around. This
    structure also provides a place for future calculated timings.

    > ---
    > Change in v7:
    > - none
    >
    > drivers/i2c/busses/i2c-rk3x.c | 55 +++++++++++++++++++++++++------------------
    > 1 file changed, 32 insertions(+), 23 deletions(-)

    Other than the description, I think this looks fine.

    IMHO this can be applied any time independent of any earlier patches.

    Reviewed-by: Douglas Anderson <dianders@chromium.org>

    \
     
     \ /
      Last update: 2016-05-06 01:21    [W:4.325 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site