Messages in this thread | | | Date | Thu, 5 May 2016 12:53:51 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH] rtc: add support for maxim rtc max6916 |
| |
Hi,
On 05/05/2016 at 03:09:49 -0700, venkat.prashanth2498@gmail.com wrote : > From: venkat-prashanth <venkat.prashanth2498@gmail.com> > > This a patch to add support for > maxim rtc max6916 > > Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com> > --- > --- > drivers/rtc/rtc-max6916.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 165 insertions(+) >
This is the second version you send since my comments. Please include the patch version in the subject line. Also, you need to include a changelog. Finally, you didn't address many of my comments please do so before submitting again.
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |