lkml.org 
[lkml]   [2016]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux/bitops.h
From
Date
On 05/04/2016 04:06 PM, Andi Kleen wrote:

> gcc always converts it before it could
[make a difference].

At the moment, current versions of gcc treat the idiomatic
ror/rol code as something they support ... but older versions
do not, and future version may not.

The gcc guys have made it very clear that they reserve the
right to do absolutely anything they want in a UB situation.
-- What is true as of today might not be "always" true.
-- What is true at one level of optimization might not be
true at another.
-- The consequences can be highly nonlocal and counterintuitive.
For example, in the case of:
rslt = word << (32 - N);
...
...
if (!N) { ....... }
the compiler could assume that N is necessarily nonzero,
and many lines later it could optimize out the whole
if-block. So, even if the "<<" operator gives the right
result, there could be ghastly failures elsewhere. It
might work for some people but not others.

> So it's unlikely to be a pressing issue.

Sometimes issues that are not urgently "pressing" ought
to be dealt with in a systematic way.

There are serious people who think that avoiding UB is
a necessity, if you want the code to be reliable and
maintainable.

I renew the question: Why did commit d7e35dfa upgrade
one of the 8 functions but not the other 7?
-- I could understand 0 of 8, or 8 of 8.
-- In contrast, I'm having a hard time understanding
why 7 of the 8 use the idiomatic expression while the
8th does not.

\
 
 \ /
  Last update: 2016-05-05 02:41    [W:0.080 / U:13.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site