lkml.org 
[lkml]   [2016]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] reset: allow to pass NULL pointer to reset_control_put()
Date
On Wednesday 04 May 2016 20:34:09 Masahiro Yamada wrote:
> I thought about that a bit,
> but there might be some (not nice) drivers that rely on the current behavior.
> I did not want to break any boards with my patch.
>
> So, should it be
>
> if (!rstc)
> return;
> or, perhaps
>
> if (!rstc || WARN_ON_ONCE(IS_ERR(rstc)))
> return;

I think the latter is fine, but it would also be good which of the six
callers of the function actually rely on that behavior today, if any.

Arnd

\
 
 \ /
  Last update: 2016-05-04 15:01    [W:0.056 / U:7.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site