lkml.org 
[lkml]   [2016]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] infoleak fix1 in signal
On 05/03, Kangjie Lu wrote:
>
> The stack object “info” has a total size of 128 bytes; however,
> only 28 bytes are initialized. The remaining uninitialized bytes
> are sent to userland via send_signal.

Not really, please see copy_siginfo_to_user(), case(__SI_CHLD). All members
copied to user-space are initialized afaics.

> @@ -1594,6 +1594,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
> sig = SIGCHLD;
> }
>
> + memset(&info, 0, sizeof(info));

looks like a false alarm to me.

Oleg.

\
 
 \ /
  Last update: 2016-05-04 13:01    [W:0.030 / U:6.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site