lkml.org 
[lkml]   [2016]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 01/27] staging: unisys: visorbus change -1 return values
    Date
    From: Erik Arfvidson <erik.arfvidson@unisys.com>

    This patch changes the vague -1 return values to -EFAULT since
    it would be the most appropriate, given that this error
    would only occur in an unexpected bad offset field.
    Resulting in a bad address.

    Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
    Signed-off-by: David Kershner <david.kershner@unisys.com>
    Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
    ---
    drivers/staging/unisys/visorbus/visorbus_main.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
    index 3a147db..d32b898 100644
    --- a/drivers/staging/unisys/visorbus/visorbus_main.c
    +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
    @@ -876,10 +876,10 @@ write_vbus_chp_info(struct visorchannel *chan,
    int off = sizeof(struct channel_header) + hdr_info->chp_info_offset;

    if (hdr_info->chp_info_offset == 0)
    - return -1;
    + return -EFAULT;

    if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
    - return -1;
    + return -EFAULT;
    return 0;
    }

    @@ -895,10 +895,10 @@ write_vbus_bus_info(struct visorchannel *chan,
    int off = sizeof(struct channel_header) + hdr_info->bus_info_offset;

    if (hdr_info->bus_info_offset == 0)
    - return -1;
    + return -EFAULT;

    if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
    - return -1;
    + return -EFAULT;
    return 0;
    }

    @@ -915,10 +915,10 @@ write_vbus_dev_info(struct visorchannel *chan,
    (hdr_info->device_info_struct_bytes * devix);

    if (hdr_info->dev_info_offset == 0)
    - return -1;
    + return -EFAULT;

    if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
    - return -1;
    + return -EFAULT;
    return 0;
    }

    --
    1.9.1
    \
     
     \ /
      Last update: 2016-06-01 04:41    [W:4.314 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site