lkml.org 
[lkml]   [2016]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking
From
> @@ -21,6 +21,9 @@ static inline int do_sys_settimeofday(const struct timespec *tv,
> struct timespec64 ts64;
>
> if (!tv)
> + return do_sys_settimeofday64(NULL, tz);
> +
> + if (tv && !timespec_valid(tv))
> return -EINVAL;

Looks like an extra check for (tv), maybe it will be better to use:
+ if (!timespec_valid(tv))

Regards, Dima.

\
 
 \ /
  Last update: 2016-06-01 04:41    [W:2.248 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site