lkml.org 
[lkml]   [2016]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] staging: iio: accel: fix error check
    On 31/05/16 22:08, Luis de Bethencourt wrote:
    > sca3000_read_ctrl_reg() returns a negative number on failure, check for
    > this instead of zero.
    >
    > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
    > Reviewed-by: Andrew F. Davis <afd@ti.com>
    > Reviewed-by: Jonathan Cameron <jic23@kernel.org>
    > ---
    >
    > Patch corrected thanks to comments from Andrew F. Davis and Jonathan Cameron.
    > https://lkml.org/lkml/2016/5/31/862
    >
    > Thanks,
    > Luis
    >
    > drivers/staging/iio/accel/sca3000_core.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
    > index a8f533a..ec12181 100644
    > --- a/drivers/staging/iio/accel/sca3000_core.c
    > +++ b/drivers/staging/iio/accel/sca3000_core.c
    > @@ -594,7 +594,7 @@ static ssize_t sca3000_read_frequency(struct device *dev,
    > goto error_ret_mut;
    > ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL);
    > mutex_unlock(&st->lock);
    > - if (ret)
    > + if (ret < 0)
    > goto error_ret;
    > val = ret;
    > if (base_freq > 0)
    >

    I sent this with git send-email using --subject-prefix="PATCH v2", no idea why the version wasn't
    added.

    Apologies,
    Luis

    \
     
     \ /
      Last update: 2016-05-31 23:21    [W:6.183 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site