Messages in this thread | | | Subject | Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c | From | Ian Abbott <> | Date | Tue, 31 May 2016 11:29:26 +0100 |
| |
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a type issues like > i.e Prefer kernel type 'u8' over 'uint8_t' > Prefer kernel type 'u16' over 'uint16_t' > Prefer kernel type 'u32' over 'uint32_t' > Prefer kernel type 's16' over 'int16_t' > Prefer kernel type 's32' over 'int32_t' > found by the checkpatch.pl tool. > > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> > --- > changes since v1: Rework > --- > drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++----------------- > 1 file changed, 106 insertions(+), 106 deletions(-) >
Thanks. It would have been nice if the checkpatch.pl tool detected _all_ the instances of these types. As a result of this patch, s626.c contains a mixture of the different integer type styles. I guess we can fix that up later though.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |