Messages in this thread | | | Subject | Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) | From | Stefan Priebe - Profihost AG <> | Date | Tue, 31 May 2016 10:03:41 +0200 |
| |
Am 31.05.2016 um 09:31 schrieb Dave Chinner: > On Tue, May 31, 2016 at 08:11:42AM +0200, Stefan Priebe - Profihost AG wrote: >>> I'm half tempted at this point to mostly ignore this mm/ behavour >>> because we are moving down the path of removing buffer heads from >>> XFS. That will require us to do different things in ->releasepage >>> and so just skipping dirty pages in the XFS code is the best thing >>> to do.... >> >> does this change anything i should test? Or is 4.6 still the way to go? > > Doesn't matter now - the warning will still be there on 4.6. I think > you can simply ignore it as the XFS code appears to be handling the > dirty page that is being passed to it correctly. We'll work out what > needs to be done to get rid of the warning for this case, wether it > be a mm/ change or an XFS change.
So is it OK to remove the WARN_ONCE in kernel code? So i don't get alarms from our monitoring systems for the trace.
Stefan
> > Cheers, > > Dave. >
| |